[llvm] [AArch64] New subtarget features to control ldp and stp formation, fo… (PR #66098)

David Green via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 14:21:23 PDT 2023


================
@@ -2136,6 +2136,18 @@ bool AArch64LoadStoreOpt::tryToPairLdStInst(MachineBasicBlock::iterator &MBBI) {
   if (!TII->isCandidateToMergeOrPair(MI))
     return false;
 
+  // Fetch the memoperand of the load/store that is a candidate for
+  // combination.
+  MachineMemOperand *memOp = MBBI->memoperands().data()[0];
----------------
davemgreen wrote:

`.data()[0]` -> `.front()` or `being()`? But does it need to check that there _is_ a memory operand too?

It could get the isLoad/isStore from MI->mayLoad() and MI->mayStore(), but the Align might well need to access the MMO.

https://github.com/llvm/llvm-project/pull/66098


More information about the llvm-commits mailing list