[PATCH] D155884: [AMDGPU] Improve indirect call support in closed modules

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:975-977
+      // Unknown value.
+      if (!SimpleV.value())
+        return false;
----------------
I don't really understand what optional with null is supposed to mean. Just drop the optional?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:979
+      // Singleton function.
+      if (isa<Function>(SimpleV.value()))
+        return true;
----------------
* instead of .value()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155884/new/

https://reviews.llvm.org/D155884