[PATCH] D151465: [Dexter] Remove builder from Dexter

Mon Sep 11 03:11:42 PDT 2023

StephenTozer added a comment.

In D151465#4642321 <https://reviews.llvm.org/D151465#4642321>, @aprantl wrote:

> @StephenTozer Yes, there are green dragon errors. It looks like -lstdc++ is hardcoded. On Darwin we usually only have libc++. Could you make that configurable?
>
> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/59897/consoleFull#12109776838254eaf0-7326-4999-85b0-388101f2d404

Looking into this, apologies for not catching the failures myself!

I see that one of the tests, `aggregate-indirect-arg.cpp`, has `-lstdc++` hardcoded in the test line; this was present prior to this patch though (specified as an `--ldflags` argument to Dexter), and none of the other tests should have any new/different flags applied to them. Is that confirmed to be the cause of the errors for the other tests? If so, it shouldn't be too hard to create a lit substitution for the command line that passes the right linker flag, but just want to verify whether there are other errors in place.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151465/new/

https://reviews.llvm.org/D151465