[llvm] [llvm] Adopt WithMarkup in the MIPS backend (PR #65384)

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 10:30:50 PDT 2023


================
@@ -213,12 +213,11 @@ void MipsInstPrinter::printMemOperand(const MCInst *MI, int opNum,
     break;
   }
 
-  O << markup("<mem:");
+  WithMarkup M = markup(O, Markup::Memory);
----------------
dsandersllvm wrote:

I'm not familiar with WithMarkup but I don't think it's very clear that this (I assume) affects the stream until it's destroyed

https://github.com/llvm/llvm-project/pull/65384


More information about the llvm-commits mailing list