[PATCH] D159399: [RISCV] Only emit .option when extension is supported

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 2 21:02:52 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:295
     RTS.emitDirectiveOptionPush();
     emitDirectiveOptionArch();
   }
----------------
Can we call `RTS.emitDirectiveOptionPush();` from `emitDirectiveOptionArch()` and have it return a bool to indicate that `RTS.emitDirectiveOptionPop()` needs to be called at the end of the function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159399/new/

https://reviews.llvm.org/D159399



More information about the llvm-commits mailing list