[PATCH] D155940: [SimplifyCFG] Transform for redirecting phis between unmergeable BB and SuccBB

Fri Sep 1 09:48:27 PDT 2023

XChy marked an inline comment as done.
XChy added a comment.

In D155940#4633497 <https://reviews.llvm.org/D155940#4633497>, @DianQK wrote:

> Too much irrelevant formatting. It causes review to become complicated. It also affects other people blame related changes.
> Could you ignore this formatting?
>
> In fact, I'm not sure why. It could be that some commits are not formatted, or it could be a change in formatting rules. Or something else.
> My formatting workflow is:
>
> - Ignore all irrelevant formatting if present.
> - Add and commit.
> - `git clang-format HEAD~1`
> - Since the latest submission is my own. Then I just run `git add .` and `git clang-format HEAD~1`.

Sorry for bringing irrelevant formatting, which may be caused by my incautious global formatting.
You workflow advice is highly appreicated.

> And why didi `stlxrb w9, w1, [x2]` became `stlxrb wzr, w1, [x2]`?

The cause is that we remove dead PHI nodes before elimination of mostly empty blocks. Actually the up-to-date llvm-repo has implemented it. You can see details in D158503 <https://reviews.llvm.org/D158503>.
I would make this patch up-to-date later.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155940/new/

https://reviews.llvm.org/D155940