[PATCH] D159254: [AArch64] Fix schedmodel pre/post-index loads and stores for Neoverse V2

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 01:34:42 PDT 2023


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

In D159254#4631353 <https://reviews.llvm.org/D159254#4631353>, @SjoerdMeijer wrote:

> Thanks for taking a look!
>
>> Are there any that test the loaded latency, not the index update?
>>
>> ldr  x1, [x27], #254
>> ldr  x2, [x1], #254
>
> I have added this test. Test file `V2-writeback.s` is a new one. I have precommitted that locally, to only show the differences here.
>
> With your test case added, and this patch applied, there is no difference before/after. In other words, the behaviour is not changed, which I think is what you wanted to check:
>
>   CHECK:      [0,0]     DeeeeER   .   ldr       x1, [x27], #254
>   CHECK-NEXT: [0,1]     D====eeeeER   ldr       x2, [x1], #254

It's not there at the moment, right? I'm not just being blind? So long as there is a test for it in the committed version then it sounds good to me. LGTM, thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159254/new/

https://reviews.llvm.org/D159254



More information about the llvm-commits mailing list