[PATCH] D155600: [AIX][TLS] Produce a faster local-exec access sequence with -maix-small-local-exec-tls (And optimize when load/store offsets are 0)

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:7633
+                   (Base.getConstantOperandVal(1) % 4 != 0))
+          continue;
+      }
----------------
hubert.reinterpretcast wrote:
> hubert.reinterpretcast wrote:
> > Please add a FIXME comment that this does not account for cases where the offset from the load/store causes the combined immediate operand to be sufficiently aligned of the instruction encoding.
> For the `else if` part here, you may want to remove it in favour of the logic at line 7723.
> Please add a FIXME comment that this does not account for cases where the offset from the load/store causes the combined immediate operand to be sufficiently aligned of the instruction encoding.

My comment above is incorrect. The offset from the load/store was already aligned for the instruction encoding, so the combination will only remain aligned if the offset from the `addi` was also a multiple of 4.

Anyhow, the check here was redundant anyway (and has been removed). The change just happens to have no functional effect.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155600/new/

https://reviews.llvm.org/D155600