[PATCH] D159139: [compiler-rt] [builtins] Remove unused/misnamed x86 chkstk functions

Thu Aug 31 02:57:14 PDT 2023

mstorsjo added a comment.

In D159139#4629039 <https://reviews.llvm.org/D159139#4629039>, @rnk wrote:

> At various points I have tried to untangle the meaning, purpose, and function of these various stack adjustment routines, and I never felt like I had a satisfactory understanding. I trust that you got to the bottom of this.

I thought I did at least; it looked to me like over-genericity from when these functions were added in the linked commits. However I just happened to look at libgcc sources, and they also have these duplicate functions (i386/x86_64 versions of both functions, complete with the unused `___chkstk` function name). So I guess the duplication and extra code stems from how they've come into place there, historically, even if not all of them actually are used. Anyway, for our purposes, I'd prefer to get rid of the unused/misleading ones, and concentrate on providing the exact ones that mingw and MSVC mode stack probes use, and nothing else.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159139/new/

https://reviews.llvm.org/D159139