[PATCH] D156354: [XRay] Only avoid outlining pseudo-instructions, not whole blocks

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 22:59:40 PDT 2023


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: sunshaoce.

LGTM.



================
Comment at: llvm/test/CodeGen/RISCV/machine-outliner-patchable.ll:80
+;; Make sure that OUTLINED_FUNCTION contains the right instructions
+; CHECK: [[OUTLINED_FUNCTION]]:
+; CHECK-NEXT:  # %bb.0:
----------------
`CHECK-LABEL:`.

It can improve FileCheck diagnostics when things go off. And IIUC, it allows reporting multiple errors after each `-LABEL:`


================
Comment at: llvm/test/CodeGen/RISCV/machine-outliner-patchable.ll:87
+; CHECK-NEXT:    jr      t0
\ No newline at end of file

----------------
No newline at end of file



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156354/new/

https://reviews.llvm.org/D156354



More information about the llvm-commits mailing list