[PATCH] D151920: [BOLT] Instrumentation: Fix tests

Wed Aug 30 10:37:08 PDT 2023

Amir added a comment.

In D151920#4626533 <https://reviews.llvm.org/D151920#4626533>, @Elvina wrote:

> In D151920#4622639 <https://reviews.llvm.org/D151920#4622639>, @Amir wrote:
>
>> Hi Elvina, this stack broke aarch64 buildbot: https://lab.llvm.org/buildbot/#/builders/221/builds/17715. You should've received a notification. Please prioritize fixing it or revert if it can't be fixed quickly.
>
> Hi! I'm trying to disable these tests in case they're building on aarch64, but I'm not sure this is the right way. Could you please take a look? https://reviews.llvm.org/D159094

Sorry, I meant specifically these tests (the buildbot is aarch64):

- instrumentation-ind-call.c: instrumented binary crashes with segfault
- basic-instrumentation.test: illegal instruction
- meta-merge-fdata.test: segfault

If needed I can provide access to the buildbot host, but it's a pretty standard Ubuntu 22.04 installation, so I'd suggest reproducing the issues locally first.

instrumentation-eh_frame_hdr.cpp and patch-entries.c will be addressed separately.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151920/new/

https://reviews.llvm.org/D151920