[PATCH] D159087: Make things less hard coded

Henrik G Olsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 05:55:17 PDT 2023


hnrklssn created this revision.
hnrklssn added a reviewer: xgupta.
Herald added a project: All.
hnrklssn requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

[patch-coverage] return to cwd after building

Updates paths to be relative to the build directory or the root
directory.

[patch-coverage] Use lit to determine test vs source code

Instead of just checking for "test" in the path and whether the filename
ends with ".ll", call lit and parse the output to determine which files
are test files.

[patch-coverage] Pass build directory and test paths as CLI args

Instead of hard-coding the build directory as "build" and test
directories as "llvm/test" and "clang/test", let the user pass them to
the CLI. Build directory is passed using -b or --build-dir, while one or
more paths to test files or directories containing tests should be
passed as positional arguments.

[patch-coverage] don't overwrite user's build config

Instead of completely reconfiguring the build directory, expect that the
user has configured it in line with their needs, and simply amend the
config to generate source coverage.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D159087

Files:
  llvm/utils/git-check-coverage

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D159087.554282.patch
Type: text/x-patch
Size: 6939 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230829/8b023dc1/attachment.bin>


More information about the llvm-commits mailing list