[PATCH] D153587: [GlobPattern] Support brace expansions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 14:23:23 PDT 2023


MaskRay added a comment.

I think we likely need to make brace expansion an opt-in feature (similar to `GLOB_BRACE` for glob). *BSD glob.h defines some arbitrary limits to prevent exponential time causing problems.
Using brace expansion in sanitizer ignore lists is totally fine and I fully support it, but other places may not want the feature with problematic time complexity (assuming that we don't implement NFA or use regex).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153587/new/

https://reviews.llvm.org/D153587



More information about the llvm-commits mailing list