[PATCH] D158317: [IR] Add SturcturalHash printer pass

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 11:03:07 PDT 2023


aeubanks added inline comments.


================
Comment at: llvm/test/Analysis/StructuralHash/structural-hash-printer.ll:17
+
+; CHECK: Module Hash: 39c8037f62da229
+; CHECK-NEXT: Function f1 Hash: b677567fe628d557
----------------
seems unfortunate to hardcode specific hashes, can we instead do something like
```
CHECK-NEXT: Function f1 Hash: [[H:([a-z0-9]{16})]]
CHECK-NEXT: Function f2 Hash: [[H:([a-z0-9]{16})]]

DETAILED-NEXT: Function f1 Hash: [[H:([a-z0-9]{16})]]
DETAILED-NOT: Function f2 Hash: [[H]]
DETAILED-NEXT: Function f2 Hash: {{([a-z0-9]{16})}}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158317/new/

https://reviews.llvm.org/D158317



More information about the llvm-commits mailing list