[PATCH] D158586: [mlir][ArmSME] Lower vector.broadcast to ArmSME

Diego Caballero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 27 21:36:49 PDT 2023


dcaballe accepted this revision.
dcaballe added a comment.

LGTM, thanks!



================
Comment at: mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp:220
+
+    auto tile = getSMETileAndCastToVector(rewriter, loc, tileType);
+
----------------
nit: spelling out some of these `auto`s would help readability


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158586/new/

https://reviews.llvm.org/D158586



More information about the llvm-commits mailing list