[PATCH] D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 27 11:05:22 PDT 2023


jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:5973
+    AAPointerInfoOffsetBins = Bins;
+  }
+
----------------
This is not a good idea. What happend to the old API you had?
We do not want to leak out the underlying map if we don't have to.
All you want is a `size` and `begin`/`end`, no?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157068/new/

https://reviews.llvm.org/D157068



More information about the llvm-commits mailing list