[PATCH] D158799: [llvm-nm][WebAssembly] Report the size of data symbols

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 16:28:52 PDT 2023


sbc100 added a comment.

In D158799#4618946 <https://reviews.llvm.org/D158799#4618946>, @sbc100 wrote:

> In D158799#4618931 <https://reviews.llvm.org/D158799#4618931>, @dschuff wrote:
>
>> actually, what about globals, e.g. __stack_pointer? Do they also have a size?
>
> No, they are of a different type.  `WASM_SYMBOL_TYPE_GLOBAL` vs `WASM_SYMBOL_TYPE_DATA`.

So in the context of this patch they would return false in the `WasmSym.isTypeData()` check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158799/new/

https://reviews.llvm.org/D158799



More information about the llvm-commits mailing list