[PATCH] D158004: llvm-nm ignore the Import symbol file for the --export-symbol option.

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 15:03:25 PDT 2023


hubert.reinterpretcast added a comment.

In D158004#4616926 <https://reviews.llvm.org/D158004#4616926>, @DiggerLin wrote:

> 2. I still prefer we previous implement the functionality in the llvm-nm as https://reviews.llvm.org/D158004?id=552000 instead of adding a new class AIXLinkerImportFile, it only effect `llvm-nm --export` , there is no other side-effect as MaskRay worry about. not sure what @hubert.reinterpretcast  and @MaskRay's opinion

I think that @MaskRay's concern about the larger-scope effects of adding `#!` magic supports going with the targeted direction of special handling for `--export`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158004/new/

https://reviews.llvm.org/D158004



More information about the llvm-commits mailing list