[PATCH] D158004: llvm-nm ignore the Import symbol file for the --export-symbol option.

[Digger Lin via Phabricator via llvm-commits]

DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/AIXLinkerImportFile.cpp:19
+
+AIXLinkerImportFile::~AIXLinkerImportFile() = default;
+Expected<std::unique_ptr<AIXLinkerImportFile>>
----------------
DiggerLin wrote:
> jhenderson wrote:
> > Please add a blank line between method defninitions.
> > 
> > That being said, why do you need an explicit destructor, rather than just not having the function present?
> without the explicit destructor , there will be compiler error.
lld with generate a linker error. please see https://lld.llvm.org/missingkeyfunction 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158004/new/

https://reviews.llvm.org/D158004