[PATCH] D154119: Fix: Distinguish CFI Metadata Checks in MergeFunctions Pass

Kyungwoo Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 21:12:55 PDT 2023


kyulee added inline comments.


================
Comment at: llvm/test/Transforms/MergeFunc/cfi-function-merging.ll:34
+
+attributes #3 = { mustprogress noinline nounwind optnone uwtable "frame-pointer"="non-leaf" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+fix-cortex-a53-835769,+neon,+outline-atomics,+v8a" }
+attributes #6 = { nocallback nofree nosync nounwind readnone speculatable willreturn }
----------------
Can you also simplify the test? 
I think you can delete attributes like `unnamed_addr #3`,  `#6`, `align 8`, etc.,, to focus on only relevant metadata..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154119/new/

https://reviews.llvm.org/D154119



More information about the llvm-commits mailing list