[PATCH] D152205: [Aarch64][SVE]SVE2] Enable tbl, tbl2 for shuffle lowering for fixed vector types.

[Dinar Temirbulatov via Phabricator via llvm-commits]

dtemirbulatov added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:25695
+  for (int Val : ShuffleMask) {
+    unsigned Offset = Val;
+    if (IsSingleOp) {
----------------
sdesmalen wrote:
> What is the point of this variable?
> 
> In my previous comment I suggested that the calculation should be done on signed values because the ShuffleMask has signed values . Doing:
> 
>   for (int Val : ShuffleMask) {
>     unsigned Offset = Val;
>     // rest of code using Offset instead of Val
>   }
> 
> does not solve that problem.
hmm, not expecting anytging harmful here, according to the specification : "Non-negative elements in the mask represent an index."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152205/new/

https://reviews.llvm.org/D152205