[PATCH] D145658: [Xtensa] Initial support of the ALU operations.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/Xtensa/XtensaISelLowering.cpp:196-199
+        if (VA.getValVT() == MVT::f32)
+          ArgValue = DAG.getNode(ISD::BITCAST, DL, VA.getValVT(), ArgValue);
+        else
+          ArgValue = DAG.getNode(ISD::TRUNCATE, DL, VA.getValVT(), ArgValue);
----------------
getNode(== f32 ? bitcast : trunc)


================
Comment at: llvm/lib/Target/Xtensa/XtensaISelLowering.cpp:211
+      // The stack pointer offset is relative to the caller stack frame.
+      int FI = MFI.CreateFixedObject(ValVT.getSizeInBits() / 8,
+                                     VA.getLocMemOffset(), true);
----------------
getStoreSize?


================
Comment at: llvm/lib/Target/Xtensa/XtensaISelLowering.cpp:220
+        // Create load nodes to retrieve arguments from the stack
+        SDValue FIN = DAG.getFrameIndex(FI, getPointerTy(DAG.getDataLayout()));
+        InVals.push_back(DAG.getLoad(
----------------
getFrameIndexTy (also this should just be the type the pointer already is)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145658/new/

https://reviews.llvm.org/D145658