[PATCH] D158458: [AsmPrinter][DebugInfo] Create EntryValue mode for DbgVariable

[Felipe de Azevedo Piovezan via Phabricator via llvm-commits]

fdeazeve added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h:126
+
+  std::set<EntryValueInfo> EntryValues;
+
----------------
aprantl wrote:
> Why not a `DenseSet<std::pair<MCRegister, DIExpression&>>` or something that inherits from std::pair, then you don't need to define any sorting/hashing methods.
Just to register an offline discussion: this wouldn't quite work as we want to sort based on the fragment offset, not directly on the value of any particular pair member.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158458/new/

https://reviews.llvm.org/D158458