[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 00:11:23 PDT 2023


MaskRay added inline comments.


================
Comment at: clang/test/Driver/hipstdpar.c:1
+// RUN: not %clang -### -hipstdpar --compile %s 2>&1 | \
+// RUN:   FileCheck --check-prefix=HIPSTDPAR-MISSING-LIB %s
----------------
Better to use `--hipstdpar` instead of `-hipstdpar`.

In GCC, `-h` is a Joined Separate option that accepts a value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155775/new/

https://reviews.llvm.org/D155775



More information about the llvm-commits mailing list