[PATCH] D158124: [dsymutil] Add support for mergeable libraries

Alpha Abdoulaye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 14:41:11 PDT 2023


Alpha added a comment.

In D158124#4601107 <https://reviews.llvm.org/D158124#4601107>, @avl wrote:

> 3. Skipping and then inserting DW_AT_APPLE_origin attribute looks a bit screwed. Can we just update it if the attribute is presented(as it is done for other attributes) and add it if the attribute does not exist?

That sounds reasonable.

For the other 2 items, I'm fine with it, most of the issues boiled down to the fact that I'm not sure what is necessarily needed for relocations outside of dsymutil, and didn't want to pull out too specific stuff in the parent interfaces
(things like `void saveRelinkedRelocs (SmallVector<ValidReloc>& Relocs)`). Looking into it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158124/new/

https://reviews.llvm.org/D158124



More information about the llvm-commits mailing list