[PATCH] D158508: [dsymutil][DWARFv5] Do output verification for DWARFv5.

[Alexey Lapshin via Phabricator via llvm-commits]

avl created this revision.
avl added reviewers: JDevlieghere, aprantl, rastogishubham.
Herald added a project: All.
avl requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

It looks like current support for DWARFv5 is good enough to have
output verification. This patch remove DWARFv5 restriction for
output verification.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158508

Files:
  llvm/tools/dsymutil/dsymutil.cpp


Index: llvm/tools/dsymutil/dsymutil.cpp
===================================================================
--- llvm/tools/dsymutil/dsymutil.cpp
+++ llvm/tools/dsymutil/dsymutil.cpp
@@ -517,10 +517,11 @@
   Binary &Binary = *BinOrErr.get().getBinary();
   if (auto *Obj = dyn_cast<MachOObjectFile>(&Binary)) {
     std::unique_ptr<DWARFContext> DICtx = DWARFContext::create(*Obj);
-    if (DICtx->getMaxVersion() >= 5) {
+    if (DICtx->getMaxVersion() > 5) {
       std::lock_guard<std::mutex> Guard(Mutex);
-      WithColor::warning() << "verification skipped for " << Arch
-                           << " because DWARFv5 is not fully supported yet.\n";
+      WithColor::warning()
+          << "verification skipped for " << Arch
+          << " because DWARF standard greater than v5 is not supported yet.\n";
       return true;
     }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158508.552323.patch
Type: text/x-patch
Size: 845 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230822/679a5af6/attachment.bin>