[PATCH] D157005: [mlir][ArmSME] Add vector to tile slice op and lowerings

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 01:31:40 PDT 2023


c-rhodes updated this revision to Diff 552261.
c-rhodes added a comment.

- Address most comments.
- Add type constraint to `VectorToTileSliceOp` that verifies 1-D vector type matches element type of 2-D vector type (tile).
- Rename `VectorToTileSliceOp::getVectorType()` -> `VectorToTileSliceOp::getTileType()` to prevent confusion with `vector` operand.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157005/new/

https://reviews.llvm.org/D157005

Files:
  mlir/include/mlir/Dialect/ArmSME/IR/ArmSME.td
  mlir/lib/Conversion/VectorToArmSME/VectorToArmSME.cpp
  mlir/lib/Dialect/ArmSME/Transforms/LegalizeForLLVMExport.cpp
  mlir/test/Dialect/ArmSME/arith-ops-to-sme.mlir
  mlir/test/Dialect/ArmSME/invalid.mlir
  mlir/test/Dialect/ArmSME/roundtrip.mlir
  mlir/test/Integration/Dialect/Vector/CPU/ArmSME/tile_fill.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157005.552261.patch
Type: text/x-patch
Size: 20215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230822/5d9c118f/attachment.bin>


More information about the llvm-commits mailing list