[PATCH] D158081: [IR] Add writable attribute

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I think there's a natural connection to dereferenceable here: "dereferenceable(N)" loads N bytes on entry, "deferenceable(N) writable" loads and stores N bytes on entry.  So gluing them together makes sense to me.



================
Comment at: llvm/docs/LangRef.rst:1537
+    This attribute is only meaningful in conjunction with ``dereferenceable(N)``
+    or another attribute that implies the first ``N`` bytes of the pointer
+    argument are dereferenceable.
----------------
I think I'd suggest dropping the "or another attribute" part; it makes it harder to reason about the semantics on the caller side.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158081/new/

https://reviews.llvm.org/D158081