[PATCH] D158081: [IR] Add writable attribute

[Nikita Popov via Phabricator via llvm-commits]

nikic updated this revision to Diff 551996.
nikic added a comment.

Pivot the definition to only be meaningful in conjunction with `dereferenceable` (or attributes implying it). Just the writability property without the data-race freedom doesn't seem particularly useful, and we only get the data race freedom with dereferenceable, so it's probably simpler to just couple these directly. (It would be nice to not have the coupling, but I don't really see a way to specify that operationally.)

Adjust the use in LICM to explicitly check for dereferenceability if required.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158081/new/

https://reviews.llvm.org/D158081

Files:
  llvm/docs/LangRef.rst
  llvm/include/llvm/Analysis/AliasAnalysis.h
  llvm/include/llvm/Bitcode/LLVMBitCodes.h
  llvm/include/llvm/IR/Attributes.td
  llvm/lib/Analysis/AliasAnalysis.cpp
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/IR/Attributes.cpp
  llvm/lib/Transforms/Scalar/LICM.cpp
  llvm/lib/Transforms/Utils/CodeExtractor.cpp
  llvm/test/Bitcode/attributes.ll
  llvm/test/Transforms/LICM/scalar-promote.ll
  llvm/test/Verifier/pointer-only-attr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158081.551996.patch
Type: text/x-patch
Size: 9708 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230821/5a32310f/attachment.bin>