[PATCH] D158324: Revert "[RegisterCoalescing] Don't move COPY if it would interfere with another value"

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 17:30:18 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/Mips/coalesce-partial-redundant-reguse-terminator.mir:27-29
+#  %1:gpr32 = COPY %0
 #
+# into bb.1 since %1 is used in the BEQ.
----------------
bjope wrote:
> Something weird here. But since it talks about hoisting I figure this used to refer to the COPY in bb.2. So then it should be %3 instead of %1.
> But then the "%3 is used in the BEQ" becomes weird. But now when it says %1 it is weird as well, because I don't see that %1 is used in any BEQ.
Yes, the comments also didn't make sense (and made less sense with the value numbering fixed)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158324/new/

https://reviews.llvm.org/D158324



More information about the llvm-commits mailing list