[PATCH] D158324: Revert "[RegisterCoalescing] Don't move COPY if it would interfere with another value"

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

One thing I don't fully understand is that the description says that the test case was wrong and did not pass verification. But you've also reverted the code and not only changed the test case.

But I figure the modified test case would pass both with and without the code changes.

So do you want to revert the code changes as well since there is no motivating test case? If so it would be nice to say something in the commit message about that (that the code is reverted even if there is no proof that it was incorrect?).

Btw. I'll try to dig a bit to see if I can track this patch back to some other test case (I suspect that uabelho has used mips64 just to find an upstream target showing the original bug).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158324/new/

https://reviews.llvm.org/D158324