[PATCH] D157483: [AIX] Handle ReadOnlyWithRel kind on AIX.

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 13:54:00 PDT 2023


DiggerLin added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-relro-section.ll:24
+; OBJ32-NEXT:     Index: 0
+; OBJ32-NEXT:     Name: <stdin>
+; OBJ32-NEXT:     Value (SymbolTableIndex): 0x0
----------------
we can delete the Name: <stdin> symbol , it is not relate the patch's functionality


================
Comment at: llvm/test/CodeGen/PowerPC/aix-relro-section.ll:54
+; OBJ32-NEXT:     Index: 3
+; OBJ32-NEXT:     Name: 
+; OBJ32-NEXT:     Value (RelocatableAddress): 0x0
----------------
we can delete the Name:  , it is not relate the patch's functionality


================
Comment at: llvm/test/CodeGen/PowerPC/aix-relro-section.ll:102
+; OBJ64-NEXT:     Index: 0
+; OBJ64-NEXT:     Name: <stdin>
+; OBJ64-NEXT:     Value (SymbolTableIndex): 0x0
----------------
ditto


================
Comment at: llvm/test/CodeGen/PowerPC/aix-relro-section.ll:131
+; OBJ64-NEXT:     Index: 3
+; OBJ64-NEXT:     Name: 
+; OBJ64-NEXT:     Value (RelocatableAddress): 0x0
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157483/new/

https://reviews.llvm.org/D157483



More information about the llvm-commits mailing list