[PATCH] D157811: [DAGCombiner] Don't merge stores to an illegal integer type

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/merge_stores_post_legalization_crash.ll:25
+
+define dso_local void @test_vec(i64* nocapture %arr1) local_unnamed_addr {
+; CHECK-LABEL: test_vec:
----------------
nemanjai wrote:
> arsenm wrote:
> > Can drop attributes and local_unnamed_addr
> I kept the attributes on one version so we can test the `noimplicitfloat` and a regular one in two functions within the same invocation of `llc`. Would you prefer that I just have one function with no attributes and just use two RUN lines?
The attributes that matter should stay, don’t need multiple invocations 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157811/new/

https://reviews.llvm.org/D157811