[PATCH] D158067: [RISCV] Bump vector crypto to v1.0 RC2

Brandon Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 20:37:19 PDT 2023


4vtomat added a comment.

In D158067#4597660 <https://reviews.llvm.org/D158067#4597660>, @craig.topper wrote:

> In D158067#4597654 <https://reviews.llvm.org/D158067#4597654>, @4vtomat wrote:
>
>> In D158067#4592569 <https://reviews.llvm.org/D158067#4592569>, @craig.topper wrote:
>>
>>> Should Zvkb and Zvbb be in this list?
>>>
>>>   void RISCVIntrinsicManagerImpl::ConstructRVVIntrinsics(                          
>>>       ArrayRef<RVVIntrinsicRecord> Recs, IntrinsicKind K) {                        
>>>     const TargetInfo &TI = Context.getTargetInfo();                                
>>>     static const std::pair<const char *, uint8_t> FeatureCheckList[] = {           
>>>         {"64bit", RVV_REQ_RV64},                                                   
>>>         {"xsfvcp", RVV_REQ_Xsfvcp}}; 
>>
>> If we add `Zvkb` and `Zvbb` to the list, we should also add other vector crypto extensions to the list right?
>
> Yes. Should be a different patch I suppose

OK, and I will have another patch to update the list for all vector crypto extensions~


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158067/new/

https://reviews.llvm.org/D158067



More information about the llvm-commits mailing list