[PATCH] D157669: Fix spurious errors that would be emitted when DW_TAG_subprogram DIEs had mutliple ranges in DW_AT_ranges.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 12:13:57 PDT 2023


clayborg added inline comments.


================
Comment at: llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp:238-240
+        if (InlineRange.empty()) {
+          ++EmptyCount;
+        } else {
----------------
kusmour wrote:
> Should we remove the curly brackets for one-line if branching?
> 
> 
If the else statement has curly brackets, I believe we need them on the "if" too, even if it is a single line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157669/new/

https://reviews.llvm.org/D157669



More information about the llvm-commits mailing list