[PATCH] D156837: [AArch64][CodeGen] Avoid inverting hot branches during relaxation

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with some nits



================
Comment at: llvm/lib/CodeGen/BranchRelaxation.cpp:85
+  // basic block that isn't in the cold section.
+  MachineBasicBlock *TrampolineInsertionPoint;
   std::unique_ptr<RegScavenger> RS;
----------------
null initialize and remove the one in scanFunction? 


================
Comment at: llvm/lib/CodeGen/BranchRelaxation.cpp:192
+    LLVM_DEBUG(dbgs() << "  No suitable trampoline insertion point found in "
+                      << MF->getName());
+  }
----------------
Need a << '\n'


================
Comment at: llvm/lib/CodeGen/BranchRelaxation.cpp:726
   BlockInfo.clear();
+  TrampolineInsertionPoint = nullptr;
 
----------------
redundant with clearing this at the start of the scan


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156837/new/

https://reviews.llvm.org/D156837