[PATCH] D158196: [emacs] Add regexps for defuns

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/utils/emacs/llvm-mode.el:102
+    (end-of-line)
+    (if (re-search-backward "^[ \t]*define[ \t]+.+[ \t]+@\\(.+\\)(.+)" nil t)
+	(match-string-no-properties 1))))
----------------
Slightly buggy.
Fails on something like:
```
define i1 @foo() {
  ret i1 true
}
```

You need `.+` -> `.*` within the parens. I.e no variables is acceptable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158196/new/

https://reviews.llvm.org/D158196