[PATCH] D156611: [llvm-cov] Support multi-source object files for `convert-for-testing`

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem accepted this revision.
gulfem added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-cov.rst:569
+
+.. code-block:: bash
+
----------------
I think there is no need for this example, so you can remove this code-block.


================
Comment at: llvm/docs/CoverageMappingFormat.rst:621
+``llvm-cov`` uses a special file format (called ``.covmapping`` below) for
+testing purpose. This format is private and should have no use for general
+users. As a developer, you can get such files by the ``convert-for-testing``
----------------
for testing purposes.


================
Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:272
+  // CoverageMappingData.
+  switch (Version) {
+  case TestingFormatVersion::Version1:
----------------
You can turn this `switch` into an `if`, as the first `case` statement is not doing anything. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156611/new/

https://reviews.llvm.org/D156611