[PATCH] D153185: [C API]: Add getters for inline assembly template string, constraints, and flags

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 16:58:03 PDT 2023


bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

In D153185#4441069 <https://reviews.llvm.org/D153185#4441069>, @Benjins wrote:

> Apologies for bumping this: not sure who I should assign it to for review, since I couldn't find many recent C API diffs. Just want to make sure it doesn't get lost

No need to apologize for bumping the thread - it's perfectly reasonable to ping a review every couple of weeks if nobody's responding. Sorry that I didn't get to this sooner!

I'm not necessarily the best reviewer for the C API, but this all looks fairly obviously correct. Do you need me to commit it for you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153185/new/

https://reviews.llvm.org/D153185



More information about the llvm-commits mailing list