[PATCH] D158011: Make _LIBUNWIND_SUPPORT_FRAME_APIS not conditional on target architecure.

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 13:55:35 PDT 2023


saugustine added a comment.

What exactly do you recommend here? The situation is pretty messy.

Today the macro only guards them for target architecture, so they are enabled for Darwin on x86 today, but not Darwin on aarch64. That is true for every single OS that runs on (one of x86, x86_64, and powerpc) and anything else.

So the same problems that exist for Darwin also exist for Fuschia and FreeBSD and many others.

Perhaps a top-level CMake option would be best.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158011/new/

https://reviews.llvm.org/D158011



More information about the llvm-commits mailing list