[PATCH] D157136: [LLD][COFF] Handle 'label' symbols when they point to a COMDAT section

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

I'm now less inclined to change the behaviour of lld to support this.  It seems that given that this is a bug in `objcopy`, it should be something that could be mitigated by using `llvm-objcopy`, and fixing binutils to correctly comdat would be more useful.  Adding additional context in the error message about the missing entries would help identify what is missing and hopefully allow the user to investigate and fix the issue?  I also suspect that this is not going to be reproducible via MSVC alone (which was the original assumption), and there are other complications from using binutils to handle PE/COFF files in my experience.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157136/new/

https://reviews.llvm.org/D157136