[PATCH] D157453: Fix "use after move" in iterator_range

Andy Kaylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 11:04:41 PDT 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rG33af74d6a02d: Fix "use after move" in iterator_range (authored by andrew.w.kaylor).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157453/new/

https://reviews.llvm.org/D157453

Files:
  llvm/include/llvm/ADT/iterator_range.h


Index: llvm/include/llvm/ADT/iterator_range.h
===================================================================
--- llvm/include/llvm/ADT/iterator_range.h
+++ llvm/include/llvm/ADT/iterator_range.h
@@ -53,8 +53,7 @@
                 detail::IterOfRange<Container>, IteratorT>::value> * = nullptr>
 #endif
   iterator_range(Container &&c)
-      : begin_iterator(adl_begin(std::forward<Container>(c))),
-        end_iterator(adl_end(std::forward<Container>(c))) {
+      : begin_iterator(adl_begin(c)), end_iterator(adl_end(c)) {
   }
   iterator_range(IteratorT begin_iterator, IteratorT end_iterator)
       : begin_iterator(std::move(begin_iterator)),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157453.550033.patch
Type: text/x-patch
Size: 656 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230814/05ac25bc/attachment.bin>


More information about the llvm-commits mailing list