[PATCH] D157290: [InstCombine] Fold (-a >> b) and/or/xor (~a >> b) into (-a and/or/xor ~a) >> b

Maksim Kita via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 12 08:07:36 PDT 2023


kitaisreal added a comment.

In D157290#4570531 <https://reviews.llvm.org/D157290#4570531>, @nikic wrote:

> Can we generalize foldBinOpShiftWithShift() to handle this? Or alternatively, can be fold foldBinOpShiftWithShift() into the special factorization case you're adding here? I'm not willing to have both. We also shouldn't be creating temporary instructions.

Moved implementation to foldBinOpShiftWithShift().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157290/new/

https://reviews.llvm.org/D157290



More information about the llvm-commits mailing list