[PATCH] D156980: [mlir][ArmSME] Extend arm_sme.zero for all types

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 05:45:31 PDT 2023


awarzynski accepted this revision.
awarzynski added a comment.

LG, thanks!



================
Comment at: mlir/test/Dialect/ArmSME/vector-ops-to-sme.mlir:163
+// arith.constant dense<0> to arm_sme.zero
+// =============================================================================
+
----------------
dcaballe wrote:
> I would suggest that we move this to a different file to avoid future refactorings.
+1

Let me land this as is (Cullen is on leave) and I will move these tests in a follow-up NFC patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156980/new/

https://reviews.llvm.org/D156980



More information about the llvm-commits mailing list