[PATCH] D157623: [lld][COFF] Remove incorrect flag from EHcont table

[namazso via Phabricator via llvm-commits]

namazso added inline comments.


================
Comment at: lld/COFF/Writer.cpp:1799
     maybeAddRVATable(std::move(ehContTargets), "__guard_eh_cont_table",
-                     "__guard_eh_cont_count", true);
 
----------------
rnk wrote:
> I think with this change the final parameter of `maybeAddRVATable` is completely dead. Would you please make a follow up change to remove the code for it?
I wasn't sure about throwing out all that code since strides exist for a reason, which is the suppression flags (currently unsupported by lld). I guess if (when) someone starts caring about them they can just add it back, in some actually usable way, as in the current one you can't actually control the contents (it's always 0).

Will make a follow-up with the removals.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157623/new/

https://reviews.llvm.org/D157623