[PATCH] D150144: cmake: add missing dependency on Attributes.inc

Alex Lorenz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 15:03:52 PDT 2023


arphaman added a comment.

The only reason why you need llvm/IR/Attributes.inc is because you're building the IR module when importing `llvm/IR/PseudoProbe.h` . It seems to me that `llvm/IR/PseudoProbe.h` could be moved out of IR and into another library that table gen can actually depend on instead, which seems sensible given that it doesn't depend on anything else in IR and other things in IR don't depend on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150144/new/

https://reviews.llvm.org/D150144



More information about the llvm-commits mailing list