[llvm] 25e2b4a - Revert "Revert "cmake: add missing dependencies on Attributes.inc""

Jon Roelofs via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 14:54:29 PDT 2023


Author: Jon Roelofs
Date: 2023-08-10T14:54:22-07:00
New Revision: 25e2b4aa1ea47d0afa37f4219b15bc218763f712

URL: https://github.com/llvm/llvm-project/commit/25e2b4aa1ea47d0afa37f4219b15bc218763f712
DIFF: https://github.com/llvm/llvm-project/commit/25e2b4aa1ea47d0afa37f4219b15bc218763f712.diff

LOG: Revert "Revert "cmake: add missing dependencies on Attributes.inc""

This reverts commit d462f65b8242a82d2430605a741825bf10ebaca0.

It breaks the modules build again, but also may inhibit the use of `-DLLVM_TABLEGEN=`.

See the discussion here: https://reviews.llvm.org/D150144#4578311

rdar://113696899

Added: 
    

Modified: 
    llvm/unittests/Analysis/CMakeLists.txt
    llvm/utils/TableGen/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Analysis/CMakeLists.txt b/llvm/unittests/Analysis/CMakeLists.txt
index c21ad3afa18a34..847430bf17697a 100644
--- a/llvm/unittests/Analysis/CMakeLists.txt
+++ b/llvm/unittests/Analysis/CMakeLists.txt
@@ -64,6 +64,8 @@ add_llvm_unittest_with_input_files(AnalysisTests
   ${ANALYSIS_TEST_SOURCES}
   )
 
+add_dependencies(AnalysisTests intrinsics_gen)
+
 target_link_libraries(AnalysisTests PRIVATE LLVMTestingSupport)
 
 # On AIX, enable run-time linking to allow symbols from the plugins shared

diff  --git a/llvm/utils/TableGen/CMakeLists.txt b/llvm/utils/TableGen/CMakeLists.txt
index bb942fb939de0f..fbd9f114b89b7d 100644
--- a/llvm/utils/TableGen/CMakeLists.txt
+++ b/llvm/utils/TableGen/CMakeLists.txt
@@ -89,6 +89,9 @@ add_tablegen(llvm-tblgen LLVM
   X86RecognizableInstr.cpp
   WebAssemblyDisassemblerEmitter.cpp
   $<TARGET_OBJECTS:obj.LLVMTableGenCommon>
+
+  DEPENDS
+  intrinsics_gen # via llvm-min-tablegen
   )
 target_link_libraries(llvm-tblgen PRIVATE LLVMTableGenGlobalISel)
 set_target_properties(llvm-tblgen PROPERTIES FOLDER "Tablegenning")


        


More information about the llvm-commits mailing list