[PATCH] D141917: WIP: Unwindabort: Implement CodeGen for DWARF-style exception handling.

[James Y Knight via Phabricator via llvm-commits]

jyknight added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:2438
+        return false;
+    } else if (!translateCallBase(CI, MIRBuilder))
+      return false;
----------------
jroelofs wrote:
> no else after return?
The else is for `CI.isInlineAsm()`, so correct as is. Might be easier to read formatted like this?
```
    if (CI.isInlineAsm()) {
      if (!translateInlineAsm(CI, MIRBuilder))
        return false;
    } else {
      if (!translateCallBase(CI, MIRBuilder))
        return false;
    }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141917/new/

https://reviews.llvm.org/D141917