[PATCH] D156468: [lld-macho] Fixed crashes when linking with incompatible-arch archives/

Thu Aug 10 07:52:00 PDT 2023

oontvoo added a comment.

In D156468#4574588 <https://reviews.llvm.org/D156468#4574588>, @gulfem wrote:

> In D156468#4574430 <https://reviews.llvm.org/D156468#4574430>, @thakis wrote:
>
>> Your fix is in now, so that's ok, but there was a 2-day window between things being known-bad and the fix landing. This causes needless work (see e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=1471633). Reverting is usually much faster than fixing, so please default to revert-first to keep trunk green (unless you have a fix that's ready to land as quickly as the revert).
>
> I confirm that https://reviews.llvm.org/D157300 fixed the issue that I reported. Reverting and relanding with a fix can save a lot time engineering time especially to toolchain maintainers when there is a confirmed issue. When a builder is broken for a few days, upcoming breakages might be masked because of that, and this makes it more difficult to bisect the new issues.

I understand. Sorry about this! It was breaking our internal builds too but I'd underestimated the time it took to fix-forward. Will watch out in the future.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156468/new/

https://reviews.llvm.org/D156468