[PATCH] D157519: [JITLink][AArch32] Tests for ELF::R_ARM_ABS32 and ELF::R_ARM_REL32

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 12:02:14 PDT 2023


sgraenitz added inline comments.


================
Comment at: llvm/test/ExecutionEngine/JITLink/AArch32/ELF_static_data_reloc.s:33
+        .global abs32
+# jitlink-check: *{4}(abs32) = target
+abs32:
----------------
Is your intention to distinguish command-lines from comments by using `//` and `#` respectively? Because then it seems you are rotating them here? All test I know use the same comment marker for both.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157519/new/

https://reviews.llvm.org/D157519



More information about the llvm-commits mailing list